1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281
#[cfg(feature = "cloud")]
use crate::cloud::set_ssl_config_for_scylla_cloud_host;
use crate::routing::{Shard, ShardCount, Sharder};
use crate::transport::errors::{
BrokenConnectionErrorKind, ConnectionError, ConnectionPoolError, QueryError,
};
use crate::transport::{
connection,
connection::{Connection, ConnectionConfig, ErrorReceiver, VerifiedKeyspaceName},
};
#[cfg(feature = "cloud")]
use super::node::resolve_hostname;
#[cfg(feature = "cloud")]
use super::node::ResolvedContactPoint;
use super::topology::{PeerEndpoint, UntranslatedEndpoint};
use super::NodeAddr;
use arc_swap::ArcSwap;
use futures::{future::RemoteHandle, stream::FuturesUnordered, Future, FutureExt, StreamExt};
use rand::Rng;
use std::convert::TryInto;
use std::num::NonZeroUsize;
use std::pin::Pin;
use std::sync::{Arc, RwLock, Weak};
use std::time::Duration;
use tokio::sync::{broadcast, mpsc, Notify};
use tracing::{debug, error, trace, warn};
/// The target size of a per-node connection pool.
#[derive(Debug, Clone, Copy)]
pub enum PoolSize {
/// Indicates that the pool should establish given number of connections to the node.
///
/// If this option is used with a Scylla cluster, it is not guaranteed that connections will be
/// distributed evenly across shards. Use this option if you cannot use the shard-aware port
/// and you suffer from the "connection storm" problems.
PerHost(NonZeroUsize),
/// Indicates that the pool should establish given number of connections to each shard on the node.
///
/// Cassandra nodes will be treated as if they have only one shard.
///
/// The recommended setting for Scylla is one connection per shard - `PerShard(1)`.
PerShard(NonZeroUsize),
}
impl Default for PoolSize {
fn default() -> Self {
PoolSize::PerShard(NonZeroUsize::new(1).unwrap())
}
}
#[derive(Clone)]
pub(crate) struct PoolConfig {
pub(crate) connection_config: ConnectionConfig,
pub(crate) pool_size: PoolSize,
pub(crate) can_use_shard_aware_port: bool,
pub(crate) keepalive_interval: Option<Duration>,
}
impl Default for PoolConfig {
fn default() -> Self {
Self {
connection_config: Default::default(),
pool_size: Default::default(),
can_use_shard_aware_port: true,
keepalive_interval: None,
}
}
}
enum MaybePoolConnections {
// The pool is being filled for the first time
Initializing,
// The pool is empty because either initial filling failed or all connections
// became broken; will be asynchronously refilled. Contains an error
// from the last connection attempt.
Broken(ConnectionError),
// The pool has some connections which are usable (or will be removed soon)
Ready(PoolConnections),
}
impl std::fmt::Debug for MaybePoolConnections {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
match self {
MaybePoolConnections::Initializing => write!(f, "Initializing"),
MaybePoolConnections::Broken(err) => write!(f, "Broken({:?})", err),
MaybePoolConnections::Ready(conns) => write!(f, "{:?}", conns),
}
}
}
#[derive(Clone)]
enum PoolConnections {
NotSharded(Vec<Arc<Connection>>),
Sharded {
sharder: Sharder,
connections: Vec<Vec<Arc<Connection>>>,
},
}
struct ConnectionVectorWrapper<'a>(&'a Vec<Arc<Connection>>);
impl std::fmt::Debug for ConnectionVectorWrapper<'_> {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
f.debug_list()
.entries(self.0.iter().map(|conn| conn.get_connect_address()))
.finish()
}
}
struct ShardedConnectionVectorWrapper<'a>(&'a Vec<Vec<Arc<Connection>>>);
impl std::fmt::Debug for ShardedConnectionVectorWrapper<'_> {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
f.debug_list()
.entries(
self.0
.iter()
.enumerate()
.map(|(shard_no, conn_vec)| (shard_no, ConnectionVectorWrapper(conn_vec))),
)
.finish()
}
}
impl std::fmt::Debug for PoolConnections {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
match self {
PoolConnections::NotSharded(conns) => {
write!(f, "non-sharded: {:?}", ConnectionVectorWrapper(conns))
}
PoolConnections::Sharded {
sharder,
connections,
} => write!(
f,
"sharded(nr_shards:{}, msb_ignore_bits:{}): {:?}",
sharder.nr_shards,
sharder.msb_ignore,
ShardedConnectionVectorWrapper(connections)
),
}
}
}
#[derive(Clone)]
pub(crate) struct NodeConnectionPool {
conns: Arc<ArcSwap<MaybePoolConnections>>,
use_keyspace_request_sender: mpsc::Sender<UseKeyspaceRequest>,
_refiller_handle: Arc<RemoteHandle<()>>,
pool_updated_notify: Arc<Notify>,
endpoint: Arc<RwLock<UntranslatedEndpoint>>,
}
impl std::fmt::Debug for NodeConnectionPool {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
f.debug_struct("NodeConnectionPool")
.field("conns", &self.conns)
.finish_non_exhaustive()
}
}
impl NodeConnectionPool {
pub(crate) fn new(
endpoint: UntranslatedEndpoint,
#[allow(unused_mut)] mut pool_config: PoolConfig, // `mut` needed only with "cloud" feature
current_keyspace: Option<VerifiedKeyspaceName>,
pool_empty_notifier: broadcast::Sender<()>,
) -> Self {
let (use_keyspace_request_sender, use_keyspace_request_receiver) = mpsc::channel(1);
let pool_updated_notify = Arc::new(Notify::new());
#[cfg(feature = "cloud")]
if pool_config.connection_config.cloud_config.is_some() {
let (host_id, address, dc) = match endpoint {
UntranslatedEndpoint::ContactPoint(ResolvedContactPoint {
address,
ref datacenter,
}) => (None, address, datacenter.as_deref()), // FIXME: Pass DC in ContactPoint
UntranslatedEndpoint::Peer(PeerEndpoint {
host_id,
address,
ref datacenter,
..
}) => (Some(host_id), address.into_inner(), datacenter.as_deref()),
};
set_ssl_config_for_scylla_cloud_host(host_id, dc, address, &mut pool_config.connection_config)
.unwrap_or_else(|err| warn!(
"SslContext for SNI connection to Scylla Cloud node {{ host_id={:?}, dc={:?} at {} }} could not be set up: {}\n Proceeding with attempting probably nonworking connection",
host_id,
dc,
address,
err
)
);
}
let arced_endpoint = Arc::new(RwLock::new(endpoint));
let refiller = PoolRefiller::new(
arced_endpoint.clone(),
pool_config,
current_keyspace,
pool_updated_notify.clone(),
pool_empty_notifier,
);
let conns = refiller.get_shared_connections();
let (fut, refiller_handle) = refiller.run(use_keyspace_request_receiver).remote_handle();
tokio::spawn(fut);
Self {
conns,
use_keyspace_request_sender,
_refiller_handle: Arc::new(refiller_handle),
pool_updated_notify,
endpoint: arced_endpoint,
}
}
pub(crate) fn update_endpoint(&self, new_endpoint: PeerEndpoint) {
*self.endpoint.write().unwrap() = UntranslatedEndpoint::Peer(new_endpoint);
}
pub(crate) fn sharder(&self) -> Option<Sharder> {
self.with_connections(|pool_conns| match pool_conns {
PoolConnections::NotSharded(_) => None,
PoolConnections::Sharded { sharder, .. } => Some(sharder.clone()),
})
.unwrap_or(None)
}
pub(crate) fn connection_for_shard(
&self,
shard: Shard,
) -> Result<Arc<Connection>, ConnectionPoolError> {
trace!(shard = shard, "Selecting connection for shard");
self.with_connections(|pool_conns| match pool_conns {
PoolConnections::NotSharded(conns) => {
Self::choose_random_connection_from_slice(conns).unwrap()
}
PoolConnections::Sharded {
connections,
sharder
} => {
let shard = shard
.try_into()
// It's safer to use 0 rather that panic here, as shards are returned by `LoadBalancingPolicy`
// now, which can be implemented by a user in an arbitrary way.
.unwrap_or_else(|_| {
error!("The provided shard number: {} does not fit u16! Using 0 as the shard number. Check your LoadBalancingPolicy implementation.", shard);
0
});
Self::connection_for_shard_helper(shard, sharder.nr_shards, connections.as_slice())
}
})
}
pub(crate) fn random_connection(&self) -> Result<Arc<Connection>, ConnectionPoolError> {
trace!("Selecting random connection");
self.with_connections(|pool_conns| match pool_conns {
PoolConnections::NotSharded(conns) => {
Self::choose_random_connection_from_slice(conns).unwrap()
}
PoolConnections::Sharded {
sharder,
connections,
} => {
let shard: u16 = rand::thread_rng().gen_range(0..sharder.nr_shards.get());
Self::connection_for_shard_helper(shard, sharder.nr_shards, connections.as_slice())
}
})
}
// Tries to get a connection to given shard, if it's broken returns any working connection
fn connection_for_shard_helper(
shard: u16,
nr_shards: ShardCount,
shard_conns: &[Vec<Arc<Connection>>],
) -> Arc<Connection> {
// Try getting the desired connection
if let Some(conn) = Self::choose_random_connection_from_slice(&shard_conns[shard as usize])
{
trace!(shard = shard, "Found connection for the target shard");
return conn;
}
// If this fails try getting any other in random order
let mut shards_to_try: Vec<u16> = (0..shard).chain(shard + 1..nr_shards.get()).collect();
let orig_shard = shard;
while !shards_to_try.is_empty() {
let idx = rand::thread_rng().gen_range(0..shards_to_try.len());
let shard = shards_to_try.swap_remove(idx);
if let Some(conn) =
Self::choose_random_connection_from_slice(&shard_conns[shard as usize])
{
trace!(
orig_shard = orig_shard,
shard = shard,
"Choosing connection for a different shard"
);
return conn;
}
}
unreachable!("could not find any connection in supposedly non-empty pool")
}
pub(crate) async fn use_keyspace(
&self,
keyspace_name: VerifiedKeyspaceName,
) -> Result<(), QueryError> {
let (response_sender, response_receiver) = tokio::sync::oneshot::channel();
self.use_keyspace_request_sender
.send(UseKeyspaceRequest {
keyspace_name,
response_sender,
})
.await
.expect("Bug in ConnectionKeeper::use_keyspace sending");
// Other end of this channel is in the Refiller, can't be dropped while we have &self to _refiller_handle
response_receiver.await.unwrap() // NodePoolRefiller always responds
}
// Waits until the pool becomes initialized.
// The pool is considered initialized either if the first connection has been
// established or after first filling ends, whichever comes first.
pub(crate) async fn wait_until_initialized(&self) {
// First, register for the notification
// so that we don't miss it
let notified = self.pool_updated_notify.notified();
if let MaybePoolConnections::Initializing = **self.conns.load() {
// If the pool is not initialized yet, wait until we get a notification
notified.await;
}
}
pub(crate) fn get_working_connections(
&self,
) -> Result<Vec<Arc<Connection>>, ConnectionPoolError> {
self.with_connections(|pool_conns| match pool_conns {
PoolConnections::NotSharded(conns) => conns.clone(),
PoolConnections::Sharded { connections, .. } => {
connections.iter().flatten().cloned().collect()
}
})
}
fn choose_random_connection_from_slice(v: &[Arc<Connection>]) -> Option<Arc<Connection>> {
trace!(
connections = v
.iter()
.map(|conn| conn.get_connect_address().to_string())
.collect::<Vec<String>>()
.join(",")
.as_str(),
"Available"
);
if v.is_empty() {
None
} else if v.len() == 1 {
Some(v[0].clone())
} else {
let idx = rand::thread_rng().gen_range(0..v.len());
Some(v[idx].clone())
}
}
fn with_connections<T>(
&self,
f: impl FnOnce(&PoolConnections) -> T,
) -> Result<T, ConnectionPoolError> {
let conns = self.conns.load_full();
match &*conns {
MaybePoolConnections::Ready(pool_connections) => Ok(f(pool_connections)),
MaybePoolConnections::Broken(err) => Err(ConnectionPoolError::Broken {
last_connection_error: err.clone(),
}),
MaybePoolConnections::Initializing => Err(ConnectionPoolError::Initializing),
}
}
}
const EXCESS_CONNECTION_BOUND_PER_SHARD_MULTIPLIER: usize = 10;
// TODO: Make it configurable through a policy (issue #184)
const MIN_FILL_BACKOFF: Duration = Duration::from_millis(50);
const MAX_FILL_BACKOFF: Duration = Duration::from_secs(10);
const FILL_BACKOFF_MULTIPLIER: u32 = 2;
// A simple exponential strategy for pool fill backoffs.
struct RefillDelayStrategy {
current_delay: Duration,
}
impl RefillDelayStrategy {
fn new() -> Self {
Self {
current_delay: MIN_FILL_BACKOFF,
}
}
fn get_delay(&self) -> Duration {
self.current_delay
}
fn on_successful_fill(&mut self) {
self.current_delay = MIN_FILL_BACKOFF;
}
fn on_fill_error(&mut self) {
self.current_delay = std::cmp::min(
MAX_FILL_BACKOFF,
self.current_delay * FILL_BACKOFF_MULTIPLIER,
);
}
}
struct PoolRefiller {
// Following information identify the pool and do not change
pool_config: PoolConfig,
// Following information is subject to updates on topology refresh
endpoint: Arc<RwLock<UntranslatedEndpoint>>,
// Following fields are updated with information from OPTIONS
shard_aware_port: Option<u16>,
sharder: Option<Sharder>,
// `shared_conns` is updated only after `conns` change
shared_conns: Arc<ArcSwap<MaybePoolConnections>>,
conns: Vec<Vec<Arc<Connection>>>,
// Set to true if there was an error since the last refill,
// set to false when refilling starts.
had_error_since_last_refill: bool,
refill_delay_strategy: RefillDelayStrategy,
// Receives information about connections becoming ready, i.e. newly connected
// or after its keyspace was correctly set.
// TODO: This should probably be a channel
ready_connections:
FuturesUnordered<Pin<Box<dyn Future<Output = OpenedConnectionEvent> + Send + 'static>>>,
// Receives information about breaking connections
connection_errors:
FuturesUnordered<Pin<Box<dyn Future<Output = BrokenConnectionEvent> + Send + 'static>>>,
// When connecting, Scylla always assigns the shard which handles the least
// number of connections. If there are some non-shard-aware clients
// connected to the same node, they might cause the shard distribution
// to be heavily biased and Scylla will be very reluctant to assign some shards.
//
// In order to combat this, if the pool is not full and we get a connection
// for a shard which was already filled, we keep those additional connections
// in order to affect how Scylla assigns shards. A similar method is used
// in Scylla's forks of the java and gocql drivers.
//
// The number of those connections is bounded by the number of shards multiplied
// by a constant factor, and are all closed when they exceed this number.
excess_connections: Vec<Arc<Connection>>,
current_keyspace: Option<VerifiedKeyspaceName>,
// Signaled when the connection pool is updated
pool_updated_notify: Arc<Notify>,
// Signaled when the connection pool becomes empty
pool_empty_notifier: broadcast::Sender<()>,
}
#[derive(Debug)]
struct UseKeyspaceRequest {
keyspace_name: VerifiedKeyspaceName,
response_sender: tokio::sync::oneshot::Sender<Result<(), QueryError>>,
}
impl PoolRefiller {
pub(crate) fn new(
endpoint: Arc<RwLock<UntranslatedEndpoint>>,
pool_config: PoolConfig,
current_keyspace: Option<VerifiedKeyspaceName>,
pool_updated_notify: Arc<Notify>,
pool_empty_notifier: broadcast::Sender<()>,
) -> Self {
// At the beginning, we assume the node does not have any shards
// and assume that the node is a Cassandra node
let conns = vec![Vec::new()];
let shared_conns = Arc::new(ArcSwap::new(Arc::new(MaybePoolConnections::Initializing)));
Self {
endpoint,
pool_config,
shard_aware_port: None,
sharder: None,
shared_conns,
conns,
had_error_since_last_refill: false,
refill_delay_strategy: RefillDelayStrategy::new(),
ready_connections: FuturesUnordered::new(),
connection_errors: FuturesUnordered::new(),
excess_connections: Vec::new(),
current_keyspace,
pool_updated_notify,
pool_empty_notifier,
}
}
fn endpoint_description(&self) -> NodeAddr {
self.endpoint.read().unwrap().address()
}
pub(crate) fn get_shared_connections(&self) -> Arc<ArcSwap<MaybePoolConnections>> {
self.shared_conns.clone()
}
// The main loop of the pool refiller
pub(crate) async fn run(
mut self,
mut use_keyspace_request_receiver: mpsc::Receiver<UseKeyspaceRequest>,
) {
debug!(
"[{}] Started asynchronous pool worker",
self.endpoint_description()
);
let mut next_refill_time = tokio::time::Instant::now();
let mut refill_scheduled = true;
loop {
tokio::select! {
_ = tokio::time::sleep_until(next_refill_time), if refill_scheduled => {
self.had_error_since_last_refill = false;
self.start_filling();
refill_scheduled = false;
}
evt = self.ready_connections.select_next_some(), if !self.ready_connections.is_empty() => {
self.handle_ready_connection(evt);
if self.is_full() {
debug!(
"[{}] Pool is full, clearing {} excess connections",
self.endpoint_description(),
self.excess_connections.len()
);
self.excess_connections.clear();
}
}
evt = self.connection_errors.select_next_some(), if !self.connection_errors.is_empty() => {
if let Some(conn) = evt.connection.upgrade() {
debug!("[{}] Got error for connection {:p}: {:?}", self.endpoint_description(), Arc::as_ptr(&conn), evt.error);
self.remove_connection(conn, evt.error);
}
}
req = use_keyspace_request_receiver.recv() => {
if let Some(req) = req {
debug!("[{}] Requested keyspace change: {}", self.endpoint_description(), req.keyspace_name.as_str());
self.use_keyspace(req.keyspace_name, req.response_sender);
} else {
// The keyspace request channel is dropped.
// This means that the corresponding pool is dropped.
// We can stop here.
trace!("[{}] Keyspace request channel dropped, stopping asynchronous pool worker", self.endpoint_description());
return;
}
}
}
trace!(
pool_state = format!("{:?}", ShardedConnectionVectorWrapper(&self.conns)).as_str()
);
// Schedule refilling here
if !refill_scheduled && self.need_filling() {
if self.had_error_since_last_refill {
self.refill_delay_strategy.on_fill_error();
} else {
self.refill_delay_strategy.on_successful_fill();
}
let delay = self.refill_delay_strategy.get_delay();
debug!(
"[{}] Scheduling next refill in {} ms",
self.endpoint_description(),
delay.as_millis(),
);
next_refill_time = tokio::time::Instant::now() + delay;
refill_scheduled = true;
}
}
}
fn is_filling(&self) -> bool {
!self.ready_connections.is_empty()
}
fn is_full(&self) -> bool {
match self.pool_config.pool_size {
PoolSize::PerHost(target) => self.active_connection_count() >= target.get(),
PoolSize::PerShard(target) => {
self.conns.iter().all(|conns| conns.len() >= target.get())
}
}
}
fn is_empty(&self) -> bool {
self.conns.iter().all(|conns| conns.is_empty())
}
fn need_filling(&self) -> bool {
!self.is_filling() && !self.is_full()
}
fn can_use_shard_aware_port(&self) -> bool {
self.sharder.is_some()
&& self.shard_aware_port.is_some()
&& self.pool_config.can_use_shard_aware_port
}
// Begins opening a number of connections in order to fill the connection pool.
// Futures which open the connections are pushed to the `ready_connections`
// FuturesUnordered structure, and their results are processed in the main loop.
fn start_filling(&mut self) {
if self.is_empty() {
// If the pool is empty, it might mean that the node is not alive.
// It is more likely than not that the next connection attempt will
// fail, so there is no use in opening more than one connection now.
trace!(
"[{}] Will open the first connection to the node",
self.endpoint_description()
);
self.start_opening_connection(None);
return;
}
if self.can_use_shard_aware_port() {
// Only use the shard-aware port if we have a PerShard strategy
if let PoolSize::PerShard(target) = self.pool_config.pool_size {
// Try to fill up each shard up to `target` connections
for (shard_id, shard_conns) in self.conns.iter().enumerate() {
let to_open_count = target.get().saturating_sub(shard_conns.len());
if to_open_count == 0 {
continue;
}
trace!(
"[{}] Will open {} connections to shard {}",
self.endpoint_description(),
to_open_count,
shard_id,
);
for _ in 0..to_open_count {
self.start_opening_connection(Some(shard_id as Shard));
}
}
return;
}
}
// Calculate how many more connections we need to open in order
// to achieve the target connection count.
let to_open_count = match self.pool_config.pool_size {
PoolSize::PerHost(target) => {
target.get().saturating_sub(self.active_connection_count())
}
PoolSize::PerShard(target) => self
.conns
.iter()
.map(|conns| target.get().saturating_sub(conns.len()))
.sum::<usize>(),
};
// When connecting to Scylla through non-shard-aware port,
// Scylla alone will choose shards for us. We hope that
// they will distribute across shards in the way we want,
// but we have no guarantee, so we might have to retry
// connecting later.
trace!(
"[{}] Will open {} non-shard-aware connections",
self.endpoint_description(),
to_open_count,
);
for _ in 0..to_open_count {
self.start_opening_connection(None);
}
}
// Handles a newly opened connection and decides what to do with it.
fn handle_ready_connection(&mut self, evt: OpenedConnectionEvent) {
match evt.result {
Err(err) => {
if evt.requested_shard.is_some() {
// If we failed to connect to a shard-aware port,
// fall back to the non-shard-aware port.
// Don't set `had_error_since_last_refill` here;
// the shard-aware port might be unreachable, but
// the regular port might be reachable. If we set
// `had_error_since_last_refill` here, it would cause
// the backoff to increase on each refill. With
// the non-shard aware port, multiple refills are sometimes
// necessary, so increasing the backoff would delay
// filling the pool even if the non-shard-aware port works
// and does not cause any errors.
debug!(
"[{}] Failed to open connection to the shard-aware port: {:?}, will retry with regular port",
self.endpoint_description(),
err,
);
self.start_opening_connection(None);
} else {
// Encountered an error while connecting to the non-shard-aware
// port. Set the `had_error_since_last_refill` flag so that
// the next refill will be delayed more than this one.
self.had_error_since_last_refill = true;
debug!(
"[{}] Failed to open connection to the non-shard-aware port: {:?}",
self.endpoint_description(),
err,
);
// If all connection attempts in this fill attempt failed
// and the pool is empty, report this error.
if !self.is_filling() && self.is_empty() {
self.update_shared_conns(Some(err));
}
}
}
Ok((connection, error_receiver)) => {
// Update sharding and optionally reshard
let shard_info = connection.get_shard_info().as_ref();
let sharder = shard_info.map(|s| s.get_sharder());
let shard_id = shard_info.map_or(0, |s| s.shard as usize);
self.maybe_reshard(sharder);
// Update the shard-aware port
if self.shard_aware_port != connection.get_shard_aware_port() {
debug!(
"[{}] Updating shard aware port: {:?}",
self.endpoint_description(),
connection.get_shard_aware_port(),
);
self.shard_aware_port = connection.get_shard_aware_port();
}
// Before the connection can be put to the pool, we need
// to make sure that it uses appropriate keyspace
if let Some(keyspace) = &self.current_keyspace {
if evt.keyspace_name.as_ref() != Some(keyspace) {
// Asynchronously start setting keyspace for this
// connection. It will be received on the ready
// connections channel and will travel through
// this logic again, to be finally put into
// the conns.
self.start_setting_keyspace_for_connection(
connection,
error_receiver,
evt.requested_shard,
);
return;
}
}
// Decide if the connection can be accepted, according to
// the pool filling strategy
let can_be_accepted = match self.pool_config.pool_size {
PoolSize::PerHost(target) => self.active_connection_count() < target.get(),
PoolSize::PerShard(target) => self.conns[shard_id].len() < target.get(),
};
if can_be_accepted {
// Don't complain and just put the connection to the pool.
// If this was a shard-aware port connection which missed
// the right shard, we still want to accept it
// because it fills our pool.
let conn = Arc::new(connection);
trace!(
"[{}] Adding connection {:p} to shard {} pool, now there are {} for the shard, total {}",
self.endpoint_description(),
Arc::as_ptr(&conn),
shard_id,
self.conns[shard_id].len() + 1,
self.active_connection_count() + 1,
);
self.connection_errors
.push(wait_for_error(Arc::downgrade(&conn), error_receiver).boxed());
self.conns[shard_id].push(conn);
self.update_shared_conns(None);
} else if evt.requested_shard.is_some() {
// This indicates that some shard-aware connections
// missed the target shard (probably due to NAT).
// Because we don't know how address translation
// works here, it's better to leave the task
// of choosing the shard to Scylla. We will retry
// immediately with a non-shard-aware port here.
debug!(
"[{}] Excess shard-aware port connection for shard {}; will retry with non-shard-aware port",
self.endpoint_description(),
shard_id,
);
self.start_opening_connection(None);
} else {
// We got unlucky and Scylla didn't distribute
// shards across connections evenly.
// We will retry in the next iteration,
// for now put it into the excess connection
// pool.
let conn = Arc::new(connection);
trace!(
"[{}] Storing excess connection {:p} for shard {}",
self.endpoint_description(),
Arc::as_ptr(&conn),
shard_id,
);
self.connection_errors
.push(wait_for_error(Arc::downgrade(&conn), error_receiver).boxed());
self.excess_connections.push(conn);
let excess_connection_limit = self.excess_connection_limit();
if self.excess_connections.len() > excess_connection_limit {
debug!(
"[{}] Excess connection pool exceeded limit of {} connections - clearing",
self.endpoint_description(),
excess_connection_limit,
);
self.excess_connections.clear();
}
}
}
}
}
#[cfg(not(feature = "cloud"))]
fn maybe_translate_for_serverless(
&self,
endpoint: UntranslatedEndpoint,
) -> impl Future<Output = UntranslatedEndpoint> {
// We are not in serverless Cloud, so no modifications are necessary here.
async move { endpoint }
}
#[cfg(feature = "cloud")]
fn maybe_translate_for_serverless(
&self,
mut endpoint: UntranslatedEndpoint,
) -> impl Future<Output = UntranslatedEndpoint> {
let cloud_config = self.pool_config.connection_config.cloud_config.clone();
async move {
if let Some(cloud_config) = cloud_config {
// If we operate in the serverless Cloud, then we substitute every node's address
// with the address of the proxy in the datacenter that the node resides in.
if let UntranslatedEndpoint::Peer(PeerEndpoint {
host_id,
ref mut address,
ref datacenter,
..
}) = endpoint
{
if let Some(dc) = datacenter.as_deref() {
if let Some(dc_config) = cloud_config.get_datacenters().get(dc) {
let hostname = dc_config.get_server();
if let Ok(resolved) = resolve_hostname(hostname).await {
*address = NodeAddr::Untranslatable(resolved)
} else {
warn!(
"Couldn't resolve address: {} of datacenter {} that node {} resides in; therefore address \
broadcast by the node was left as address to open connection to.",
hostname, dc, host_id
);
}
} else {
warn!( // FIXME: perhaps error! would fit here better?
"Datacenter {} that node {} resides in not found in the Cloud config; ; therefore address \
broadcast by the node was left as address to open connection to.",
dc, host_id
);
}
} else {
warn!( // FIXME: perhaps error! would fit here better?
"Datacenter for node {} is empty in the Metadata fetched from the Cloud cluster; ; therefore address \
broadcast by the node was left as address to open connection to.",
host_id
);
}
}
endpoint
} else {
// We are not in serverless Cloud, so no modifications are necessary here.
endpoint
}
}
}
// Starts opening a new connection in the background. The result of connecting
// will be available on `ready_connections`. If the shard is specified and
// the shard aware port is available, it will attempt to connect directly
// to the shard using the port.
fn start_opening_connection(&self, shard: Option<Shard>) {
let cfg = self.pool_config.connection_config.clone();
let endpoint = self.endpoint.read().unwrap().clone();
// If we operate in the serverless Cloud, then we substitute every node's address
// with the address of the proxy in the datacenter that the node resides in.
// As this may may involve resolving a hostname, the whole operation is async.
let endpoint_fut = self.maybe_translate_for_serverless(endpoint);
let fut = match (self.sharder.clone(), self.shard_aware_port, shard) {
(Some(sharder), Some(port), Some(shard)) => async move {
let shard_aware_endpoint = {
let mut endpoint = endpoint_fut.await;
endpoint.set_port(port);
endpoint
};
let result = open_connection_to_shard_aware_port(
shard_aware_endpoint,
shard,
sharder.clone(),
&cfg,
)
.await;
OpenedConnectionEvent {
result,
requested_shard: Some(shard),
keyspace_name: None,
}
}
.boxed(),
_ => async move {
let non_shard_aware_endpoint = endpoint_fut.await;
let result =
connection::open_connection(non_shard_aware_endpoint, None, &cfg).await;
OpenedConnectionEvent {
result,
requested_shard: None,
keyspace_name: None,
}
}
.boxed(),
};
self.ready_connections.push(fut);
}
fn maybe_reshard(&mut self, new_sharder: Option<Sharder>) {
if self.sharder == new_sharder {
return;
}
debug!(
"[{}] New sharder: {:?}, clearing all connections",
self.endpoint_description(),
new_sharder,
);
self.sharder.clone_from(&new_sharder);
// If the sharder has changed, we can throw away all previous connections.
// All connections to the same live node will have the same sharder,
// so the old ones will become dead very soon anyway.
self.conns.clear();
let shard_count = new_sharder.map_or(1, |s| s.nr_shards.get() as usize);
self.conns.resize_with(shard_count, Vec::new);
self.excess_connections.clear();
}
// Updates `shared_conns` based on `conns`.
// `last_error` must not be `None` if there is a possibility of the pool
// being empty.
fn update_shared_conns(&mut self, last_error: Option<ConnectionError>) {
let new_conns = if self.is_empty() {
Arc::new(MaybePoolConnections::Broken(last_error.unwrap()))
} else {
let new_conns = if let Some(sharder) = self.sharder.as_ref() {
debug_assert_eq!(self.conns.len(), sharder.nr_shards.get() as usize);
PoolConnections::Sharded {
sharder: sharder.clone(),
connections: self.conns.clone(),
}
} else {
debug_assert_eq!(self.conns.len(), 1);
PoolConnections::NotSharded(self.conns[0].clone())
};
Arc::new(MaybePoolConnections::Ready(new_conns))
};
// Make the connection list available
self.shared_conns.store(new_conns);
// Notify potential waiters
self.pool_updated_notify.notify_waiters();
}
// Removes given connection from the pool. It looks both into active
// connections and excess connections.
fn remove_connection(&mut self, connection: Arc<Connection>, last_error: ConnectionError) {
let ptr = Arc::as_ptr(&connection);
let maybe_remove_in_vec = |v: &mut Vec<Arc<Connection>>| -> bool {
let maybe_idx = v
.iter()
.enumerate()
.find(|(_, other_conn)| Arc::ptr_eq(&connection, other_conn))
.map(|(idx, _)| idx);
match maybe_idx {
Some(idx) => {
v.swap_remove(idx);
true
}
None => false,
}
};
// First, look it up in the shard bucket
// We might have resharded, so the bucket might not exist anymore
let shard_id = connection
.get_shard_info()
.as_ref()
.map_or(0, |s| s.shard as usize);
if shard_id < self.conns.len() && maybe_remove_in_vec(&mut self.conns[shard_id]) {
trace!(
"[{}] Connection {:p} removed from shard {} pool, now there is {} for the shard, total {}",
self.endpoint_description(),
ptr,
shard_id,
self.conns[shard_id].len(),
self.active_connection_count(),
);
if self.is_empty() {
let _ = self.pool_empty_notifier.send(());
}
self.update_shared_conns(Some(last_error));
return;
}
// If we didn't find it, it might sit in the excess_connections bucket
if maybe_remove_in_vec(&mut self.excess_connections) {
trace!(
"[{}] Connection {:p} removed from excess connection pool",
self.endpoint_description(),
ptr,
);
return;
}
trace!(
"[{}] Connection {:p} was already removed",
self.endpoint_description(),
ptr,
);
}
// Sets current keyspace for available connections.
// Connections which are being currently opened and future connections
// will have this keyspace set when they appear on `ready_connections`.
// Sends response to the `response_sender` when all current connections
// have their keyspace set.
fn use_keyspace(
&mut self,
keyspace_name: VerifiedKeyspaceName,
response_sender: tokio::sync::oneshot::Sender<Result<(), QueryError>>,
) {
self.current_keyspace = Some(keyspace_name.clone());
let mut conns = self.conns.clone();
let address = self.endpoint.read().unwrap().address();
let connect_timeout = self.pool_config.connection_config.connect_timeout;
let fut = async move {
let mut use_keyspace_futures = Vec::new();
for shard_conns in conns.iter_mut() {
for conn in shard_conns.iter_mut() {
let fut = conn.use_keyspace(&keyspace_name);
use_keyspace_futures.push(fut);
}
}
if use_keyspace_futures.is_empty() {
return Ok(());
}
let use_keyspace_results: Vec<Result<(), QueryError>> = tokio::time::timeout(
connect_timeout,
futures::future::join_all(use_keyspace_futures),
)
.await
.map_err(|_| QueryError::TimeoutError)?;
super::cluster::use_keyspace_result(use_keyspace_results.into_iter())
};
tokio::task::spawn(async move {
let res = fut.await;
match &res {
Ok(()) => debug!("[{}] Successfully changed current keyspace", address),
Err(err) => warn!("[{}] Failed to change keyspace: {:?}", address, err),
}
let _ = response_sender.send(res);
});
}
// Requires the keyspace to be set
// Requires that the event is for a successful connection
fn start_setting_keyspace_for_connection(
&mut self,
connection: Connection,
error_receiver: ErrorReceiver,
requested_shard: Option<Shard>,
) {
// TODO: There should be a timeout for this
let keyspace_name = self.current_keyspace.as_ref().cloned().unwrap();
self.ready_connections.push(
async move {
let result = connection.use_keyspace(&keyspace_name).await;
if let Err(err) = result {
warn!(
"[{}] Failed to set keyspace for new connection: {}",
connection.get_connect_address().ip(),
err,
);
}
OpenedConnectionEvent {
result: Ok((connection, error_receiver)),
requested_shard,
keyspace_name: Some(keyspace_name),
}
}
.boxed(),
);
}
fn active_connection_count(&self) -> usize {
self.conns.iter().map(Vec::len).sum::<usize>()
}
fn excess_connection_limit(&self) -> usize {
match self.pool_config.pool_size {
PoolSize::PerShard(_) => {
EXCESS_CONNECTION_BOUND_PER_SHARD_MULTIPLIER
* self
.sharder
.as_ref()
.map_or(1, |s| s.nr_shards.get() as usize)
}
// In PerHost mode we do not need to keep excess connections
PoolSize::PerHost(_) => 0,
}
}
}
struct BrokenConnectionEvent {
connection: Weak<Connection>,
error: ConnectionError,
}
async fn wait_for_error(
connection: Weak<Connection>,
error_receiver: ErrorReceiver,
) -> BrokenConnectionEvent {
BrokenConnectionEvent {
connection,
error: error_receiver.await.unwrap_or_else(|_| {
ConnectionError::BrokenConnection(BrokenConnectionErrorKind::ChannelError.into())
}),
}
}
struct OpenedConnectionEvent {
result: Result<(Connection, ErrorReceiver), ConnectionError>,
requested_shard: Option<Shard>,
keyspace_name: Option<VerifiedKeyspaceName>,
}
async fn open_connection_to_shard_aware_port(
endpoint: UntranslatedEndpoint,
shard: Shard,
sharder: Sharder,
connection_config: &ConnectionConfig,
) -> Result<(Connection, ErrorReceiver), ConnectionError> {
// Create iterator over all possible source ports for this shard
let source_port_iter = sharder.iter_source_ports_for_shard(shard);
for port in source_port_iter {
let connect_result =
connection::open_connection(endpoint.clone(), Some(port), connection_config).await;
match connect_result {
Err(err) if err.is_address_unavailable_for_use() => continue, // If we can't use this port, try the next one
result => return result,
}
}
// Tried all source ports for that shard, give up
Err(ConnectionError::NoSourcePortForShard(shard))
}
#[cfg(test)]
mod tests {
use super::open_connection_to_shard_aware_port;
use crate::routing::{ShardCount, Sharder};
use crate::test_utils::setup_tracing;
use crate::transport::connection::ConnectionConfig;
use crate::transport::node::ResolvedContactPoint;
use crate::transport::topology::UntranslatedEndpoint;
use std::net::{SocketAddr, ToSocketAddrs};
// Open many connections to a node
// Port collision should occur
// If they are not handled this test will most likely fail
#[tokio::test]
#[cfg(not(scylla_cloud_tests))]
async fn many_connections() {
setup_tracing();
let connections_number = 512;
let connect_address: SocketAddr = std::env::var("SCYLLA_URI")
.unwrap_or_else(|_| "127.0.0.1:9042".to_string())
.to_socket_addrs()
.unwrap()
.next()
.unwrap();
let connection_config = ConnectionConfig {
compression: None,
tcp_nodelay: true,
#[cfg(feature = "ssl")]
ssl_config: None,
..Default::default()
};
// This does not have to be the real sharder,
// the test is only about port collisions, not connecting
// to the right shard
let sharder = Sharder::new(ShardCount::new(3).unwrap(), 12);
// Open the connections
let mut conns = Vec::new();
for _ in 0..connections_number {
conns.push(open_connection_to_shard_aware_port(
UntranslatedEndpoint::ContactPoint(ResolvedContactPoint {
address: connect_address,
datacenter: None,
}),
0,
sharder.clone(),
&connection_config,
));
}
let joined = futures::future::join_all(conns).await;
// Check that each connection managed to connect successfully
for res in joined {
res.unwrap();
}
}
}